Comment 1 for bug 568128

Since branch access is transitive, it is impossible to have a public branch on a private one. I expect the page to show the privacy ribbon to convey the situation.

We may want to redesign how lp treats this scenario in the data.

I do not think the lower branch should be set as private when pushed because the lower branch could become private after the higher is created. Changing the lower branch to public should not make the high branch public since it might contain private information.

I think the visibility rule (which is actually in play) is correct. The rules to check for visibility are wrong. IPrivacy(stacked_branch) is not checking if the lower branch is private. It wrongly says the branch is public, so the privacy ribbon is missing. The visibility portlet does not check properly either. The portlet should say that the branch is private because the lower branch is private.