Comment 4 for bug 494807

Revision history for this message
Aaron Bentley (abentley) wrote : Re: [Bug 494807] [NEW] code review mail shouldn't mention already-merged bugs

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Tim Penhey wrote:
> On Thu, 10 Dec 2009 13:30:27 Martin Pool wrote:
>> Public bug reported:
>> Maybe they should only mention bugs fixed in the proposed branch and not
>> in the target, or alternatively only bugs fixed in the unmerged
>> revisions.
>
> The problem with this is that bugs are linked to branches, not revisions.
> Launchpad can't know that you are reusing a branch for a different reason.

Sure. On the other hand, if the bug was linked to the target branch,
then we would already be filtering it out, via BMP.related_bugs.

So Martin could address this by unlinking the bug from the source branch
(since the source branch no longer has the purpose of fixing this bug),
or by linking it to the target branch (since the target branch also
fixes the bug).

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEUEARECAAYFAkshDTsACgkQ0F+nu1YWqI2FPgCYsoymWZO8dJ8L0UoDW4zbCeTs
UQCfS3mI2je0MUOvCqNbhiRmgDRhMCw=
=EiEo
-----END PGP SIGNATURE-----