Comment 13 for bug 492145

2009/12/9 Aaron Bentley <email address hidden>:
>> I'm asking that the mail should make clear:
>>
>>  * who has been asked to review it: you personally, a team to which
>> you belong, or something else
>
> I believe this request is based on the misapprehension that it is
> possible for this kind of mail to be sent when the receipient has not
> personally been asked to do the review.

The web interface does have a action "request review from team" so I
think it's likely that many people will believe this. Also, I think
it's a bug (possibly a complicated bug) that it doesn't
<https://bugs.edge.launchpad.net/launchpad-code/+bug/281056>.

> I think that clarification like "You, not a team you are in, have been
> requested to review..." would actually encourage people to believe that
> a similar message *could* be sent when a team that they were in was
> requested to perform a review.
>
> We could tweak the wording slightly, but if people accept the plain
> meaning of the phrase "You have been requested...", they will correctly
> understand the situation.  I don't see a great need for clarification.

Perhaps the best way to clarify it is along the lines spiv suggests:
just list all the currently pending reviews? That's useful
information anyhow.

> I don't think Code Review should consider it key if Launchpad need never
> know about it.  It may make sense to review the commit message at the
> same time as the code, to ensure that it, too is up to quality
> standards, but it's not an essential ingredient.
>
> For code reviews of any complexity, the cover letter is at least a
> helpful guide, and often an absolute necessity.  I think that making
> them supplementary would make code review much harder to do.

Maybe this should be a separate bug?

--
Martin <http://launchpad.net/~mbp/>