Comment 10 for bug 492145
Revision history for this message
| Aaron Bentley (abentley) wrote Re: [Bug 492145] Re: email about updated mp diffs includes obsolete/misleading cover letter | #10 |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
35a32c5
(Get the code!)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Martin Pool wrote:
> Sorry, "subscribe" was inaccurate. I meant distinguishing "you have
> been requested to review" because ~bzr-core is asked to review all of
> them
That isn't really what happens. ~bzr-core is the review team for
lp:bzr, which means that it is the *default* reviewer for all proposed
merges into lp:bzr, but it doesn't mean that it is asked to review all
branches. Even when it is, this doesn't cause its members to receive
any email.
Separately, ~bzr-core is subscribed to code review email on lp:bzr,
which means that its members receive email about code review involving
lp:bzr, whether or not they have been requested to review.
> vs "you personally have been requested to review"
This is the only case where this message is sent.
>, and also
> distinguishing resubmitted from original mps.
Oh, I thought you were talking about re-requesting a review.
> If there was a separate cover letter field, we would need to work out
> how that meshes with the intended commit message.
I don't think they're similar. They have different formats and target
audiences.
> Perhaps it should
> be cast as being supplementary to the commit message and also empty.
I think that the cover letter is essential, while the commit message is
not. Why do you think it should be supplementary?
> Also we would need some view on the ordering of events when somebody
> pushes an update to the branch: if you are going to send mail about
> the update, perhaps it would be best to send it when both the cover
> letter and the diff have been updated, but they are done separately.
> Perhaps it's enough to send them separately, but with a short delay
> (as in bugs?) to give them a chance to get into the same email.
At present, there's no message sent about updated diffs, so we can
design any such feature however we like and there's no reason to assume
that they would be done separately.
Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://
iEYEARECAAYFAks
C8UAnjE1qvYhunC
=T7Ug
-----END PGP SIGNATURE-----