Comment 9 for bug 338002

2009/6/11 Aaron Bentley <email address hidden>:
> I think the right thing is to make resubmit nicer.
>
> Review diffs are meant to be static.  They reflect the change that you
> asked to be merged.  That ensures that everyone discussing the change is
> discussing the same thing.

I wonder if that's a different or larger bug.

It's true that nontrivial proposals may go through several
submissions. Ideally you'd see them all linked together, so you can
see the history of conversation, but also, if you want, see which
particular patch people were talking about with every comment.

However, in practice, I'm not sure that's highly needed. Normally the
updates are fairly small, and it's clear from the context or the
quoted text what people were talking about at any time. Also,
typically the patch is additive: if someone asks for fix X and you see
the patch now fixes X it's only of slight interest most of the time to
see what it was like before.-

For really long running patches or ones where somebody takes a step
back and does a completely new version it may be more complicated, but
it may be enough to just let people make a new proposal in that case.

So, maybe eventually you want the review comments to say eg

 On 2009-06-04 John wrote (_about an older version of this proposal_)

with a link.

--
Martin <http://launchpad.net/~mbp/>