Comment 5 for bug 338002

Revision history for this message
James Westby (james-w) wrote : Re: [Bug 338002] Re: 'Review Diff' on merge proposal page can be out-of-date

On Mon, 2009-06-08 at 23:35 +0000, Martin Pool wrote:
> I just noticed this again in https://code.edge.launchpad.net/~edwin-
> grubbs/bzr/bug-384158-passing-body-to-mutt/+merge/7142 where,
> suprisingly to me, the list of to-be-merged revisions shown above the
> diff is inconsistent with what's in the diff.

It seems to me that removing the diff if the source branch changes
would lead to less confusion; an incorrect diff is worse than a
missing one.

Obviously updating the diff would be more useful, but if that isn't
going to happen the above would be a better compromise in my opinion.

Thanks,

James