Comment 4 for bug 326056
Revision history for this message
| Monty Taylor (mordred) wrote Re: OOPS on InvalidStateTransition when reviewing code by mail | #4 |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
I just hit this, and it seems like it might be slightly more common than just an edge case. In particular, it seems to take several minutes from the time I send an email and it winds its way through all of the various servers involved until launchpad processes it.
On the other hand, it's quite possible for me to push a merged revision in less time than it takes for the email to work - so there's a race condition where I approve email, commit, push, email arrives.
Also, honestly, if the merge request is auto-marked approved because it's been merged, and then the merge approval comes in, I think I'd rather see the message get added than an error thrown, given that the two intended states do not conflict.
My €0.02