Comment 1 for bug 326056
Revision history for this message
| Aaron Bentley (abentley) wrote Re: [Bug 326056] [NEW] OOPS on InvalidStateTransition when reviewing code by mail | #1 |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Paul Hummer wrote:
> So I did a code review for Entertainer and sent it, then immediately
> merged the branch into trunk and pushed up to launchpad. The scanner
> apparently marked the BMP as merged before my review with ' status
> approved' could get handled. This resulted in this oops:
> https:/
It's possible for something to be merged that is not approved, and it's
possible for something to be approved that isn't merged. So I think
that our model is slightly wrong. The ideal model would have two status
flags:
code review status: inactive, pending, approved, disapproved
merge status: inactive, queued, merged
If our model reflected this, then setting the review status to approved
would not change the merge status, and we could not get errors like this.
Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://
iEYEARECAAYFAkm
ULYAn0GNmRB3Ru6
=itMw
-----END PGP SIGNATURE-----