Launchpad itself

Bug #281476
Comment #9

Comment 9 for bug 281476

Revision history for this message

Bryce Harrington (bryce) wrote on 2011-03-10:

Fwiw, getting the filename slows down run time quite a bit:

        for a in attachments:
            try:
                dbg_run_time(start_time, "+ a-start")
                a_file_name = a.filename
                dbg_run_time(start_time, "+ a-get-filename")
                a_title = a.title
                dbg_run_time(start_time, "+ a-get-title")
                a_owner = a.owner.display_name
                dbg_run_time(start_time, "+ a-get-owner")
                a_age = a.age
                dbg_run_time(start_time, "+ a-get-age")
                a_ispatch = a.is_patch()
                dbg_run_time(start_time, "+ a-get-is-patch")
                a_url = a.url
                dbg_run_time(start_time, "+ a-get-url")

[Wed Mar 09 21:30:02 2011] [error] [client 74.107.147.166] [56.855120] process-attachment
[Wed Mar 09 21:30:06 2011] [error] [client 74.107.147.166] [60.330161] + a-start
[Wed Mar 09 21:30:07 2011] [error] [client 74.107.147.166] [61.712297] + a-get-filename
[Wed Mar 09 21:30:07 2011] [error] [client 74.107.147.166] [61.712457] + a-get-title
[Wed Mar 09 21:30:07 2011] [error] [client 74.107.147.166] [61.713700] + a-get-owner
[Wed Mar 09 21:30:07 2011] [error] [client 74.107.147.166] [61.715955] + a-get-age
[Wed Mar 09 21:30:07 2011] [error] [client 74.107.147.166] [61.716996] + a-get-is-patch
[Wed Mar 09 21:30:07 2011] [error] [client 74.107.147.166] [61.717967] + a-get-url
[Wed Mar 09 21:30:07 2011] [error] [client 74.107.147.166] [61.718162] process-attachment
[Wed Mar 09 21:30:12 2011] [error] [client 74.107.147.166] [66.407895] + a-start
[Wed Mar 09 21:30:14 2011] [error] [client 74.107.147.166] [68.737491] + a-get-filename
[Wed Mar 09 21:30:14 2011] [error] [client 74.107.147.166] [68.737662] + a-get-title
[Wed Mar 09 21:30:14 2011] [error] [client 74.107.147.166] [68.738906] + a-get-owner
[Wed Mar 09 21:30:14 2011] [error] [client 74.107.147.166] [68.739992] + a-get-age
[Wed Mar 09 21:30:14 2011] [error] [client 74.107.147.166] [68.741006] + a-get-is-patch
[Wed Mar 09 21:30:14 2011] [error] [client 74.107.147.166] [68.741972] + a-get-url

Just retrieving the filename alone takes 1.5-2.0 seconds per attachment. Many bugs I process easily have a couple dozen attachments (from apport), so this can be a rather big performance hit.

Fwiw, getting the filename slows down run time quite a bit:

for a in attachments:
            try:
                dbg_run_time(start_time, "+ a-start")
                a_file_name = a.filename
                dbg_run_time(start_time, "+ a-get-filename")
                a_title     = a.title
                dbg_run_time(start_time, "+ a-get-title")
                a_owner     = a.owner.display_name
                dbg_run_time(start_time, "+ a-get-owner")
                a_age       = a.age
                dbg_run_time(start_time, "+ a-get-age")
                a_ispatch   = a.is_patch()
                dbg_run_time(start_time, "+ a-get-is-patch")
                a_url       = a.url
                dbg_run_time(start_time, "+ a-get-url")

Just retrieving the filename alone takes 1.5-2.0 seconds per attachment.  Many bugs I process easily have a couple dozen attachments (from apport), so this can be a rather big performance hit.