Comment 44 for bug 250820
Revision history for this message
| Matt Zimmerman (mdz) wrote Re: [Bug 250820] Re: -changes emails could be easier to read | #44 |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
73416ba
(Get the code!)
On Mon, Sep 01, 2008 at 04:42:44PM -0000, Colin Watson wrote:
> Thanks, this is largely fine, assuming that the .changes will be
> attached in the real thing. As Matt said, a blank line would help. Also:
>
> * We are used to reading changelog trailer lines as " -- name <e-mail> date" (note leading space, and two spaces between e-mail and date; it would be helpful to match that.
Agreed.
> * Using the Maintainer for the changelog trailer line is weird, because it doesn't correspond to what would be in the real changelog. I suggest using Changed-By for this instead (Bhavani Shankar in this case), and including a Maintainer: line for ubuntu-motu. Matt summarised the possibilities in comments 16 and 17 to this bug, which could be turned into test cases.
Agreed.
> * It would be better for the synthesised changelog trailer line to be just below the first changelog block, rather than right at the end. As it is, it looks as if ubuntu-motu (or Bhavani) was responsible for version 0.8.14-2, which isn't the case; that trailer line belongs with version 0.8.17-11ubuntu1.
This is going to be awkward no matter what, since the relevant data is
currently lost and the format doesn't degrade gracefully. I suppose you're
right, though. The additional changelog stanzas without maintainer fields
will look weird, but not much weirder than the current example.
--
- mdz