Comment 34 for bug 250820

Revision history for this message
Colin Watson (cjwatson) wrote :

Since I was asked for my sign-off, I'm by and large in favour of this change.

The one thing I remain unsure of is how we're handling uploads that include changelog entries from multiple package versions in their .changes file. Matt suggested extracting the information from debian/changelog in the uploaded source package, which I think is a good idea, but this is definitely worth a test case.

It is important to include at least some data for all the changelog entries in the .changes file in the announcement mails (contrast this with /ubuntu/+source/SP, which doesn't reliably do this). It is desirable to preserve the trailer line from each changelog entry that names the person responsible; failing that, we must not synthesise trailer lines because that could reassign credit to the wrong person, and it would be better just to leave out trailer lines if we can't create them correctly.

I've attached a .changes file that would make a decent test case. It corresponds to https://launchpad.net/ubuntu/+source/fbreader/0.8.17-11ubuntu1; note that the change information displayed on https://launchpad.net/ubuntu/+source/fbreader is truncated, which is what we don't want to happen to announcement mails. I'd like to see what the announcement mail for this upload would have looked like under the new system.