Comment 9 for bug 201749

Revision history for this message
Adi Roiban (adiroiban) wrote :

New chat for reference:

20:03 danilos : adiroiban, I am about to call it a day, is there anything I can do to help out while I am still here? :)
20:03 adiroiban : yes
20:03 adiroiban : can you please explain
20:04 adiroiban : in simple words
20:04 adiroiban : what should „needs review” do
20:04 adiroiban : from the point of view of users
20:04 adiroiban : it should just set the translation to empty
20:04 adiroiban : and mark the current translation as needs reviewn ?
20:04 adiroiban : review?
20:05 adiroiban : danilos: ^ :)
20:05 adiroiban : or it should dismiss the current translation?
20:06 adiroiban : and just leave the message untranslated
20:06 danilos : adiroiban, well
20:06 danilos : adiroiban, I think it should do that and leave all the other unreviewed suggestions as unreviewed
                   suggestions
20:07 danilos : adiroiban, the message should end up untranslated, but with the previous active translation as another
                   suggestion added to the existing set of suggestions
20:07 adiroiban : ok
20:08 adiroiban : and then, listing ALL suggestions should be another bug and should be displayed only in the zoom in view
20:08 danilos : adiroiban, btw, look at dismissAllSuggestions for a few ideas
20:08 danilos : adiroiban, that's right, and there's already that "another" bug filed :)
20:09 adiroiban : danilos: yes. I think I am assigned to that bug
20
:09 danilos : adiroiban, bug 339507
20:09 mup : Bug #339507: translation page should show old translations <ui> <Launchpad Translations:Triaged by
                   adiroiban> <https://launchpad.net/bugs/339507>
20:09 danilos : adiroiban, right
20:10 adiroiban : but I was thinking we can force showing all suggestions
20:10 danilos : adiroiban, and do take care of the TranslationConflict in a similar way (when someone changes translations
                   after you have loaded the page)
20:10 adiroiban : by ticking the needs review
20:10 danilos : adiroiban, we shouldn't
20:10 adiroiban : danilos: ok :)
20:10 danilos : adiroiban, we'll get a very confusing behaviour of 'needs review'
20:11 adiroiban : danilos: ok. Many thanks!
20:11 danilos : adiroiban, now, you can perhaps say "it would make the implementation much easier, so I'd do that as a
                   first step/branch", and then I'd agree :)