Comment 2 for bug 172501
Revision history for this message
| Eleanor Berger (intellectronica) wrote Re: reject non-code patch attachements | #2 |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
From an email thread with mdz and dholbach:
> > It should be possible to identify attachments that are patches
> > programmatically, at least to some degree of reliability. Maybe that
> > would be more useful than asking the user to indicate whether they're
> > attaching a patch?
>
> That's a good point. Given that it's possible to attach diffs which aren't
> actually patches to fix the bug (which, as I understand it, is what this
> flag is meant for), this couldn't replace the checkbox, but it could
> definitely prevent this type of mistake.
>
> Could we ignore the value of the checkbox if the content is not a diff?
Or maybe add a confirmation step (in cases where the value of the
checkbox and the content of the attachment are in conflict). Ignoring
form elements is (imho) not a good idea.