Comment 11 for bug 172501

Revision history for this message
Emmet Hikory (persia) wrote : Re: reject non-code patch attachements

Abel,
    I think you're putting too much interpretation into the location of a diff. My experience with that class of patch has been that it's either a one-line change (and so may be easier to copy/paste from another window than to construct a file and load as an attachment), or a result of someone not being sufficiently motivated to learn that Malone expects patches to be uploaded inline. Some of the patches that have been presented to me in this way were both useful and appeared to be the correct solution.

    That said, I'm unsure that there is any value in someone extracting such a diff and uploading as a file just to set a flag, which flag I expect to become a significant attractor of developer attention once widely present. bugsquad could surely do it, and it may only be occasional patches that are submitted that way, but as long as an interface is being designed, I'd think it oughtn't be hard to allow for manual tweaking of the result in some way.