Comment 10 for bug 172501
Revision history for this message
| Abel Deuring (adeuring) wrote Re: reject non-code patch attachements | #10 |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
Emmet,
> In the case of inline patches, it would be nice if it didn't requrie
> someone to extract the patch and resubmit it as an attachment or branch,
> but rather just add a tag or press a button.
I have some doubts about this. Sure, if somebody is too lazy to add a really useful patch as an attchment and simply pastes it into a comment, the information "we have a patch" is lost. But including the diff in a comment may also indicate that the commenter simply wants to say "I know, this is a crappy workaround, but it fixes my actual problem", thus indicating that s/he does not expect the diff to be used as a real fix. Or am I putting too much interpretation into the location of a diff?