Comment 5 for bug 1281

> > One of the pre-conditions for users to merge accounts is that the "from
> > account" (the one that's going to cease existing) can't have any email
> > addresses. I think we should keep this for the admin interface, because
> > if the "from account" has one or more dead email addresses, we don't
> > want to move them to the other account.
>
> I think the email addresses should just be moved over, either flagged as NEW
> or OLD. Probably NEW for now, as I don't think users have a way of
> reactivating OLD email addresses yet (?).
>

Yes, they don't have a way to reactivate an OLD email address yet.

> Alternatively, they could just be deleted.
>
> > If we do this, to merge any account with dead email addresses will
> > require someone with write access to the production database to go there
> > and delete these dead email addresses. IMO, deleting these emails
> > manually is not a big deal, and on the other hand it'll make it harder
> > to cause harm by merging wrong user accounts.
>
> In almost every case where we need to use this feature, this manual step
> would need to be taken. I don't see any point keeping it manual when it
> would be trivial to handle it automatically.

Indeed it's trivial to handle automatically, I suggested that because the
merge of user accounts might be quite harmful if, let's say, a launchpad admin
inadvertently merge the wrong account. If they had to manually delete the
email addresses, they'd have another chance to realize that's the wrong
account. This is not ideal, obviously, but I think that if we're going to
provide a web interface for an operation that is not easily reversible
(or maybe it is?), we need some extra care to make sure we won't ever need
to revert one.