OOPS claiming a merge proposal
Bug #507487 reported by
Diogo Matsubara
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
High
|
Paul Hummer | ||
Bug Description
Steps to reproduce:
1. Create a merge proposal and assign it to the the default review team. (e.g. https:/
2. Go to the unclaimed merge propsal page assigned to the review team. (e.g. https:/
3. Using the ajax comment at the bottom, leave a comment and approve the merge proposal
4. The table at the middle will still show the MP as "claimable" assigned to the default review team.
5. Click the "Claim review" button
6. OOPS-1474EB604 ClaimReviewFailed: The review is not pending.
What should happen: On step 3, the table shown on step 4 should be updated with the new state for the MP
Related branches
lp:~rockstar/launchpad/update-review-table-on-comment
- Tim Penhey (community): Approve
-
Diff: 931 lines (+437/-396)6 files modifiedMakefile (+0/-1)
lib/canonical/launchpad/javascript/lp/comment.js (+28/-0)
lib/canonical/launchpad/javascript/lp/lp-mochi.js (+383/-0)
lib/canonical/launchpad/javascript/lp/lp.js (+0/-392)
lib/lp/app/templates/base-layout-macros.pt (+11/-3)
lib/lp/code/windmill/tests/test_branchmergeproposal_review.py (+15/-0)
Revision history for this message
| Paul Hummer (rockstar) wrote | #1 |
| Changed in launchpad-code: | |
| status: | New → In Progress |
| importance: | Undecided → High |
| assignee: | nobody → Paul Hummer (rockstar) |
| milestone: | none → 10.01 |
Revision history for this message
| Paul Hummer (rockstar) wrote | #2 |
Revision history for this message
| Paul Hummer (rockstar) wrote | #3 |
| Changed in launchpad-code: | |
| status: | In Progress → Fix Committed |
| Changed in launchpad-code: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
This will be fixed when bug #496532 is fixed.