Reviews on comments don't update the reviewer list
Bug #496532 reported by
John O'Brien
This bug affects 2 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
High
|
Paul Hummer | ||
Bug Description
This was seen on edge:
I was assigned as a reviewer to a merge proposal
When I entered my review comments I just entered them on the review page and didn't click the review link next to my name in the reviewer list. When I approved the branch my approval was not updated next to my name.
Related branches
lp:~rockstar/launchpad/update-review-table-on-comment
- Tim Penhey (community): Approve
-
Diff: 931 lines (+437/-396)6 files modifiedMakefile (+0/-1)
lib/canonical/launchpad/javascript/lp/comment.js (+28/-0)
lib/canonical/launchpad/javascript/lp/lp-mochi.js (+383/-0)
lib/canonical/launchpad/javascript/lp/lp.js (+0/-392)
lib/lp/app/templates/base-layout-macros.pt (+11/-3)
lib/lp/code/windmill/tests/test_branchmergeproposal_review.py (+15/-0)
| affects: | launchpad → launchpad-code |
Revision history for this message
| Tim Penhey (thumper) wrote | #1 |
| tags: | added: ajax confusing-ui |
| Changed in launchpad-code: | |
| assignee: | nobody → Paul Hummer (rockstar) |
| importance: | Undecided → High |
| status: | New → Triaged |
Revision history for this message
| Martin Pool (mbp) wrote Re: [Bug 496532] Re: Reviews on comments don't update the reviewer list | #2 |
Revision history for this message
| Paul Hummer (rockstar) wrote | #3 |
Revision history for this message
| Paul Hummer (rockstar) wrote | #4 |
| Changed in launchpad-code: | |
| status: | Triaged → In Progress |
Revision history for this message
| Paul Hummer (rockstar) wrote | #5 |
| Changed in launchpad-code: | |
| status: | In Progress → Fix Committed |
| Changed in launchpad-code: | |
| milestone: | none → 10.01 |
| Changed in launchpad-code: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Hi Paul, more JS for you.