Launchpad itself

exceptions.AttributeError: 'NoneType' object has no attribute 'write'

Bug #340295 reported by Jonathan Lange
2
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Michael Hudson-Doyle
Launchpad itself 10.03

Bug Description

I'm not sure what triggers this OOPS. It occurs in ssh_CHANNEL_DATA, but beyond that I haven't investigated.

OOPS-1164SMPSSH1, OOPS-1164SMPSSH2

Related branches

lp:~mwhudson/launchpad/ssh-errors-on-stderr-bug-335156
Jonathan Lange (community): Approve
Diff: 112 lines (+30/-9)
2 files modified
lib/lp/codehosting/sshserver/session.py (+8/-5)
lib/lp/codehosting/sshserver/tests/test_session.py (+22/-4)
Jonathan Lange (jml)
Changed in launchpad-bazaar:
importance: Undecided → High
status: New → Triaged
Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

This is still happening intermittently, and still a complete mystery afaik.

Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

Surprisingly, this seems to be related to bug #335156.

Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

FWIW, I think this happens when the client continues to send data after we've disconnected, or we disconnect part way through processing what the client has already sent. So the linked branch won't fix the bug in absolute terms, but it will make our only supported client behave more sensibly and not trigger the OOPS any more.

Revision history for this message
Ursula Junque (ursinha) wrote : Bug fixed by a commit

Fixed in stable r10516 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/10516>

Changed in launchpad-code:
assignee: nobody → Michael Hudson (mwhudson)
milestone: none → 10.03
status: Triaged → Fix Committed
tags: added: qa-needstesting
Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

Tentatively marking qa-ok.. we won't really know that this has worked until we've had a whole month without this oops, or something like that.

Michael Hudson-Doyle (mwhudson)
tags: added: qa-ok
removed: qa-needstesting
Tim Penhey (thumper)
Changed in launchpad-code:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.