"not allowed to execute..." message sent over ssh stdout channel
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
Medium
|
Michael Hudson-Doyle | ||
Bug Description
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
With the latest bzr client (1.12 or bzr.dev) if you try to use
'bzr+ssh://' to connect to a remote host but it is either missing, or
you have BZR_REMOTE_PATH set incorrectly, you get a series of:
$ BZR_REMOTE_
lp:~jameinel/bzr/jam-integration
Server does not understand Bazaar network protocol 3, reconnecting.
(Upgrade the server to avoid this.)
Server does not understand Bazaar network protocol 2, reconnecting.
(Upgrade the server to avoid this.)
bzr: ERROR: Generic bzr smart protocol error: Server is not a Bazaar
server: Received bad protocol version marker: "Not allowed to execute
'/home/jameinel/bzr serve --inet --directory=/ --allow-writes
'.\r\n"
So Launchpad is refusing the connection with an error, and this is
causing the bzr client to spin repeatedly, rather than aborting.
John
=:->
affects bzr
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://
iEYEARECAAYFAkm
KNIAnA7Qqe0sNRd
=tvh4
-----END PGP SIGNATURE-----
Related branches
- Jonathan Lange (community): Approve
-
Diff: 112 lines (+30/-9)2 files modifiedlib/lp/codehosting/sshserver/session.py (+8/-5)
lib/lp/codehosting/sshserver/tests/test_session.py (+22/-4)
| Martin Pool (mbp) wrote | #1 |
| affects: | bzr → launchpad-code |
| summary: |
- Poor response when unable to connect to remote bzr + "not allowed to execute..." message sent over ssh stdout channel |
| Michael Hudson-Doyle (mwhudson) wrote | #2 |
| Changed in launchpad-code: | |
| importance: | Undecided → Medium |
| status: | New → In Progress |
| assignee: | nobody → Michael Hudson (mwhudson) |
| milestone: | none → 10.03 |
| Ursula Junque (ursinha) wrote Bug fixed by a commit | #3 |
| Changed in launchpad-code: | |
| status: | In Progress → Fix Committed |
| tags: | added: qa-needstesting |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in launchpad-code: | |
| status: | Fix Committed → Fix Released |
This probably means that Launchpad is sending the message to the ssh stdout channel when it should be sending it to stderr. bzr's behaviour is not ideal but not unreasonably imo.