Comment 13 for bug 2006402

Revision history for this message
Mitch Burton (mitchburton) wrote :

Thanks for looking at this Steve, and thanks for the additional context Dave.

Steve, I'm not sure what the takeaway is from the "individual bugs in changelog" part of this discussion. Should I remove the bug refs except for the ones that impact packaging changes under debian/ ? If so, I'll do that right away.

Your inference is correct, this change was made to accommodate cases where landscape-client is upgrading itself (see https://github.com/CanonicalLtd/landscape-client/commit/7448c4924e111493f214be9c4f06779653756ecf). I'll create a bug to address this change. I've already performed some testing, as detailed in https://wiki.canonical.com/Landscape/ClientSRUTests/23.02, but noticeably missing from those testcases is "upgrade with landscape client not running", so I'll get that done and update the testing report.

I've added a comment to LP:1968189 that I hope adequately explains the use of systemctl kill in that change.