Imported or opened image isn't displayed

What was the previous revision you tested that didn't show this bug??

Inkscape r22221 on OS X 10.5.8 doesn't show any artifacts when moving or rescaling imported images. The images are displayed as expected.

Confirmed on Ubuntu 9.04, Inkscape rev.22232.
And no thumbnail appear when selection the bitmap in the file browser (linked to Bug #429593?).

I don't remember number of the previous version but it was compiled
two days ago.

-------

Dnia Mon, 14 Sep 2009 20:11:56 -0000 ~suv
<email address hidden> napisał/a:

>What was the previous revision you tested that didn't show this bug??
>
>--
>Imported or opened image isn't displayed
>https://bugs.launchpad.net/bugs/429610
>You received this bug notification because you are a direct subscriber
>of the bug.

maybe related to revision 22228? It's the only recent commit that only effects images.
<http://inkscape.svn.sourceforge.net/viewvc/inkscape?view=rev&revision=22228>
as fix for bug #168384 “Image pixels don't align with grid”

any console messages?

Nope, there are no errors nor warnings.

-------

Dnia Mon, 14 Sep 2009 21:03:04 -0000 ~suv
<email address hidden> napisał/a:

>maybe related to revision 22228? It's the only recent commit that only
>effects images.
><http://inkscape.svn.sourceforge.net/viewvc/inkscape?view=rev&revision=22228>
>as fix for bug #168384 “Image pixels don't align with grid”
>
>any console messages?
>
>--
>Imported or opened image isn't displayed
>https://bugs.launchpad.net/bugs/429610
>You received this bug notification because you are a direct subscriber
>of the bug.

On OS X 10.5.8 I have now tested builds with

svn update -r 22227
svn update -r 22228
svn update -r 22231
svn update -r 22232

and cannot reproduce the error... ? Imported or opened bitmaps (PNG, JPG, GIF) are displayed as well as are thumbnails in the gtk file chooser dialog. The only additional patch I didn't revert was 'BUG238796_display_toggle.patch' from bug #238796 - but this should not interfere with this bug.

Works well with rev. 22227, NOT with rev. 22228.
I also confirm this change is the cause of Bug #429593.

Unfortunately I haven't been able to reproduce this yet. But I wonder: are you all using a 32 bit OS? My patch uses the "long long" type which is 64 bits. I expected this to be handled by the compiler, but maybe I was mistaken? You might already have guessed that I'm running 64 bits Linux myself.

bug not reproduced on OS X 10.5.8 (32bit OS)

LeWitt:~ suv$ arch
i386
LeWitt:~ suv$ uname -a
Darwin LeWitt.local 9.8.0 Darwin Kernel Version 9.8.0: Wed Jul 15 16:55:01 PDT 2009; root:xnu-1228.15.4~1/RELEASE_I386 i386
LeWitt:~ suv$ gcc --version
i686-apple-darwin9-gcc-4.0.1 (GCC) 4.0.1 (Apple Inc. build 5493)
LeWitt:~ suv$ g++ --version
i686-apple-darwin9-g++-4.0.1 (GCC) 4.0.1 (Apple Inc. build 5493)

  Model Name: MacBook Pro
  Model Identifier: MacBookPro5,1
  Processor Name: Intel Core 2 Duo
  Processor Speed: 2.4 GHz
  Number Of Processors: 1
  Total Number Of Cores: 2
  L2 Cache: 3 MB
  Memory: 2 GB

I confirm I can reproduce it on Ubuntu 9.04, 32bits.

This bug was caused by the patch attached to bug 168384. This patch has been reverted though, so everything should be working properly again.

BTW thanks everyone for tracking this down, even to the exact revision, this really helped a lot!

Fixed in 22289 from my own tests. Thanks Diederik!