Comment 6 for bug 172219

Revision history for this message
meientau (jan-schormann) wrote :

I don't think I'm quite ready yet to really join the project, so I don't really know what I'm doing here - please give it a thorough review.
However, the patch works fine for me and is rather short, so maybe someone can give it a review and it might just go into 0.48.x?
That would be soooo cool.

The attached patch contains 2 distinct issues:

1.) As stated above, dc->xtilt and dc->ytilt behaved strangely for me.
NOTE: I did not observe the strangeness in a vanilla 0.47 installation, and I don't understand where the values come from, but:

In the latest version I got from the repository, the values read from the tablet have a range from about -900 to +900 (I assume it's really meant to be -1024.0 to +1023.0 as found in the Wacom docs), but are then (in sp_dyna_draw_extinput()) CLAMPed to [-1...1], which isn't very helpful.
Why divide by 1024? To retain the full resolution, the resulting value should always be smaller than the clamp limits to prevent cut-off, but I assume the values will never be above 1024 (absolute).

2.) More to the original point of this report: to calculate the final nib angle, I just add up the fixed part and the part calculated from the tilt. Thereby we gain the flexibility of defining the angle between the tilted pen and the nib, just by entering a value in the nib angle input box.

I would now like to be able to not disable the input field for the fixed nib angle, because it is now still valid even if tilt is active. But I don't understand the code in toolbox.cpp, if that's the right place at all.
Also, I'm not sure how to train/explain the fact that there is a difference on how pressure is used to calculate width, and tilt is used to calculate the angle, but I really strongly believe that this behavior is more like "what you want".

I know that's a far shot - how would I go about to get feedback on whether other people support this change or not?