Comment 6 for bug 634003
Revision history for this message
| Mark Shuttleworth (sabdfl) wrote Re: [Bug 634003] Re: Restart to complete updates entry should be red | #6 |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
35a32c5
(Get the code!)
On 10/09/10 05:50, Bilal Akhtar wrote:
> On Thu, 2010-09-09 at 19:51 +0000, Mark Shuttleworth wrote:
>> We definitely don't want arbitrary colour requests in dbusmenu! For the
>> moment, I'd rather special-case this in indicator-session. I assume
>> there's some flag being set which tells the indicator to use the red
>> icon, it could use the same thing to make that menu entry red.
> >From what I am seeing in the indicator-session code, there are two
> different icons, one based on the theme and the other hard-coded red,
> and there is no such flag that changes the colour, so I am taking this
> approach.
>
That's really ugly, the "restart required" piece should be semantic or
logically expressed, so it can be tested by other pieces, rather than
depending on a hardcoded icon. Ted!
What's the situation with messaging menu? Is the "alert" state semantic,
or hardcoded to a green icon too?
We really need to express these capabilities has higher-order logic not
low-level painting.
Mark