Comment 3 for bug 1564317

Revision history for this message
Gert van den Berg (mohag1) wrote :

The simplest fix is to replace the "continue" in the recode error handlers with "exit(1)" (Patched html2text.C lines 595 and 555). (Using a different value for encoding errors might be useful)

This makes the error handling consistent with other cases, like failing to open a file. (See line 482)

A better solution would be to keep track of whether an error occurred in the loop and then change the final return value based on that. (Requiring changes to add a variable declaration, and on lines 482, 510, 555, 582 and 595)

(Line numbers are from the patched Wily version)