Comment 5 for bug 357206

Revision history for this message
Darren Worrall (dazworrall) wrote :

Ok, my branch now behaves like that - Checkbox enable/disable in the view menu. When disabled, the tab is hidden, and updates are not requested - I had to add another parameter to add_msg_tab and add_scrolled_parent - let me know if those changes are acceptable :)

I have come across an issue which I'm not sure how to tackle though; when notification bubbles are enabled, they are spammed by messages from the public timeline, to the point where they drown out 'genuine' message notifications, or worse, system ones.

How do you feel is the best way to identify if a message is from a public timeline, so that we can (optionally?) exclude them from show_notification_bubbles? Just a case of adding another property to the protocol's Message class and plumbing that in per protocol? Set up a base class for all the protocols to use with a view to moving all the common properties into that - or is that impractical, given the different plumbing protocols inevitably employ? </brain dump>

Thanks for any feedback :)

Side note - I'm going to try to hack in friendfeed public timeline support tonight to check it can handle multiple public feeds correctly.