[wishlist] Public Timeline Tab

Bug #357206 reported by Mathias Menzer
4
Affects Status Importance Assigned to Milestone
Gwibber
Fix Released
Wishlist
Unassigned

Bug Description

I'm proposing a third tab that (optionally) shows the public timeline of the subscribed services as shown on their home pages.

Related branches

Dominic Evans (oldmanuk)
summary: - [Wishlist] Public Timeline Tab
+ [wishlist] Public Timeline Tab
Changed in gwibber:
importance: Undecided → Wishlist
status: New → Confirmed
Revision history for this message
Darren Worrall (dazworrall) wrote :

I wouldn't mind taking a stab at this - would anyone be available to mentor, or is there any gwibber documentation I could read up on?

Thanks

Revision history for this message
Darren Worrall (dazworrall) wrote :

Ok, first attempt at anything like this, so feedback appreciated :) Published a branch with a public timeline preference, and support for twitter.

Suggestions for how to implement a global enable/disable would be appreciated.

Revision history for this message
Ryan Paul (segphault) wrote :

Nice work! Perhaps for a global enable/disable, we could have a checkbox item in the View menu that toggles the visibility of a public tab. When the tab is visible, the accounts that have the public stream enabled will be aggregated together into that tab. What do you think?

Revision history for this message
Darren Worrall (dazworrall) wrote :

Sounds reasonable, I'll give it a go - thanks :)

Revision history for this message
Darren Worrall (dazworrall) wrote :

Ok, my branch now behaves like that - Checkbox enable/disable in the view menu. When disabled, the tab is hidden, and updates are not requested - I had to add another parameter to add_msg_tab and add_scrolled_parent - let me know if those changes are acceptable :)

I have come across an issue which I'm not sure how to tackle though; when notification bubbles are enabled, they are spammed by messages from the public timeline, to the point where they drown out 'genuine' message notifications, or worse, system ones.

How do you feel is the best way to identify if a message is from a public timeline, so that we can (optionally?) exclude them from show_notification_bubbles? Just a case of adding another property to the protocol's Message class and plumbing that in per protocol? Set up a base class for all the protocols to use with a view to moving all the common properties into that - or is that impractical, given the different plumbing protocols inevitably employ? </brain dump>

Thanks for any feedback :)

Side note - I'm going to try to hack in friendfeed public timeline support tonight to check it can handle multiple public feeds correctly.

Revision history for this message
Darren Worrall (dazworrall) wrote :

Branch now has friendfeed public timeline support, and I've also re-factored the code to support the idea of a tab which can be toggled, rather than code specific for the public tab.

Revision history for this message
Darren Worrall (dazworrall) wrote :

As per irc conversation, notifications for public timeline messages are now disabled - tabs now have a show_notifications property, which is true by default.

Revision history for this message
Darren Worrall (dazworrall) wrote :

Pushed one more version, which will clear the contents of the tab when hidden. I noticed afterwards that the clearMessages() function referenced in client.py doesn't appear to be implemented yet, but figured I'd leave the code, it does no harm at the moment.

Not sure if it was right, but I used the 'bzr --fixes' switch on this bug as per the bazaar docs. Should I also propose the branch for merging, or is that traditionally done by a maintainer?

Revision history for this message
Ryan Paul (segphault) wrote :

You can propose merges yourself. I'll do a complete review this weekend and then get it into trunk. It's looking really good! :-)

Revision history for this message
Darren Worrall (dazworrall) wrote :

Done, let me know if you want anything changing :)

Revision history for this message
Ryan Paul (segphault) wrote :

@Darren: Thanks for contributing this feature! :-)

Changed in gwibber:
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.