Comment 86 for bug 434476

Revision history for this message
In , Cpearce-t (cpearce-t) wrote :

Comment on attachment 8401684
Implement WakeLockListener on Linux to disable screensaver while video is playing

Review of attachment 8401684:
-----------------------------------------------------------------

This is the behaviour we want (locking video irrespective of whether we're fullscreen or not), but someone who has a clue about Linux should also review this. Karl?

::: widget/gtk/nsAppShell.cpp
@@ +93,5 @@
> + FREEDESKTOP_SCREENSAVER_OBJECT,
> + FREEDESKTOP_SCREENSAVER_INTERFACE,
> + p_method);
> + }
> + else {

} else {

@@ +120,5 @@
> + DBUS_TYPE_STRING, &application,
> + DBUS_TYPE_STRING, &reason,
> + DBUS_TYPE_INVALID);
> + }
> + else {

} else {

@@ +391,1 @@
> return nsBaseAppShell::Init();

You should probably remove the listener during shutdown too.