Comment 79 for bug 434476

Revision history for this message
In , Cpearce-t (cpearce-t) wrote :

Comment on attachment 693331
v2

Review of attachment 693331:
-----------------------------------------------------------------

::: widget/gtk2/nsAppShell.cpp
@@ +167,5 @@
> + {
> + if(!mConnection)
> + return NS_ERROR_FAILURE;
> +
> + if(!topic.Equals(NS_LITERAL_STRING("DOM_Fullscreen")))

I don't think we should only disable the screen saver when we're playing fullscreen video. I think we should do it whenever video is playing, provided playback was initiated in a user generated event handler.

I'll write a patch to ensure that we only send the notification if we're in a user generated event handler. In the meantime, we can make the topic here "screen".