Comment 5 for bug 129081

Revision history for this message
Cesare Tirabassi (norsetto) wrote :

Hi Torvald,

Thanks indeed for your interest. There is a number of points that I had asked Justin to forward to you. Let me paste them here in case you haven't got them (in no particular order):

1) The upstream tarball must not contain a debian directory, upstream should exclude it in their dist target.

2) The .desktop file doesn't validate, and should be corrected as follow:

- the "Encoding" key is deprecated.
- a semicolon should be added as trailing character in the "Categories" key.
- the Icon entry should not use an extension

3) Copyright/License

Your LICENSE quote Copyright (C) 2005-2007, Thorvald Natvig <email address hidden>, but some of the included
source files seem to be copyrighted far before this date. There seem also to be some other copyrighters:

        Xiph.org Foundation
        Jean-Marc Valin
        David Rowe
        EpicGames
        Analog Devices
        Commonwealth Scientific and Industrial Research Organisation (CSIRO)
        Mark Borgerding
        Jutta Degener and Carsten Bormann
        Christopher Montgomery

The files bits.c (File: speex_bits.c) and jitter.c (File: speex_jitter.h) headers should be corrected.

speex/libspeex/kiss_fft.h doesn't have a copyright notice.

mallfft.c, speex_types.h and smallfft.h are not licensed through a BSD license.

4) I have seen some .ts files which seems to provide translation of the program in some languages. They don't seem to be installed though; is this is done on purpose?