Comment 2 for bug 563050

Revision history for this message
Daniel Manrique (roadmr) wrote :

Hello, the following information should complete this bug as a valid SRU report, to hopefully upload this fix to Lucid.

Solution:
Checkbox revision 788 does checking for gconfd-2 in addition to the gnome-panel, to determine whether it can use gconftool to get user preferences. So it will use gconftool to fetch the preferred browser if the system is running either gnome-panel (desktop) or gconfd-2 (UNR). Note that a desktop system runs gconfd-2 BUT a UNR system will NOT be running gnome-panel. However, either one has support for gconftool.

TEST CASE:

This is a bit awkward to confirm as it can possibly interact with bug 562580 in ways that make it unclear which fix is at work.

1- Perform fresh install of UNR 10.04
2- Install chromium-browser or midori
3- Set chromium or midori as the default browser in System -> preferred applications.
4- Apply the code changes for bug 562580, to use Popen.wait() to get the gnome preferred browser.
5- Launch system testing.
6- Do a test run (deselect all tests in the selection screen).
7- Click on "View report" in the summary screen.

The report will open in Firefox instead of the preferred browser (chromium or midori) confirming that the user preference wasn't honored.

Since the fix for bug 562580 was applied, we can be certain that this problem is caused by something else.

Applying the proposed fix makes the report open in the preferred browser (chrome or midori).

Regression potential:
The code just changes a pgrep regular expression to search for gnome-panel or gconfd-2. Thus the only chance of a regression from this would be a situation where the user's preference not being honored *was* the desired behavior, such as an invalid or broken browser being configured, but such an scenario is extremely unlikely. The call to pgrep itself is unlikely to fail or produce unwanted behavior.