bzr patch doesn't understand query strings in URLs

Bug #310631 reported by Max Kanat-Alexander
6
Affects Status Importance Assigned to Milestone
BzrTools
New
Undecided
Unassigned

Bug Description

This is possibly related to bug 242828. If I ask for a patch using a URL with a query string, bzr tells me the file doesn't exist:

bzr patch https://bugzilla.mozilla.org/attachment.cgi?id=353873
bzr: ERROR: No such file: 'https://bugzilla.mozilla.org/attachment.cgi%3Fid%3D353873'

However, that URL does exist and there definitely is a file there. Note that it's converting the ? to %3F and = to %3D when it shouldn't be escaping those at all.

Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

This seems to come down to this:

<mwhudson> james_w: bzrlib.transport.Transport._unsplit_url says in the docstring
<mwhudson> Build the full URL for the given already URL encoded path.
<mwhudson> but then escapes the path anyway

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.