On Mon, 2009-08-24 at 09:14 +0000, Martin Pool wrote:
> My attached branch changes bzrlib.commit to not use
> path_contents_summary. It adds a new tree method
> get_kind_and_executable_from_path so that we can observe the kind and
> execute bit in one stat call, but so that we don't promise to do any
> more work than that.
>
> I still need to add a test for that new method, deprecate
> path_contents_summary, and fix up the TreeTransform use of that
> method.
Is the semantics of the new method clearly defined vis-a-vis content
filters? E.g. a filter that forces all files without a #! to be
non-executable.
On Mon, 2009-08-24 at 09:14 +0000, Martin Pool wrote:
> My attached branch changes bzrlib.commit to not use summary. It adds a new tree method and_executable_ from_path so that we can observe the kind and summary, and fix up the TreeTransform use of that
> path_contents_
> get_kind_
> execute bit in one stat call, but so that we don't promise to do any
> more work than that.
>
> I still need to add a test for that new method, deprecate
> path_contents_
> method.
Is the semantics of the new method clearly defined vis-a-vis content
filters? E.g. a filter that forces all files without a #! to be
non-executable.
-Rob