Bazaar

  1. Bug #415508
  2. Comment #11

Comment 11 for bug 415508

Revision history for this message
Robert Collins (lifeless) wrote : Re: [Bug 415508] Re: Content filtering breaks commit w/ merge parents

On Mon, 2009-08-24 at 01:09 +0000, Martin Pool wrote:
>
> seems reasonable, but seems to indicate that we'd want a test for
> record_entry_contents (or a larger function, up to commit), checking
> that it gets the canonical size from the tree, not the convenient
> size.
> Even if this interface is renamed, there'd still be a chance commit
> was
> using the wrong one and we ought to test it.

record_entry_contents is the right method to test; testing commit will
run the risk of using the fast code path and not actually testing the
code we want to.

We should also rename the API and drop the size field from it. Which
will prevent it being used wrongly.

-Rob