Comment 3 for bug 406687

Revision history for this message
Robert Collins (lifeless) wrote : Re: [Bug 406687] Re: insert_stream doesn't check references are satisfied

On Mon, 2009-08-31 at 10:03 +0000, Andrew Bennetts wrote:
>
> So, my short term plan is to propose a merge for a patch doesn't reuse
> check, but will at least catch missing chk entries. This will
> insulate
> us from gross bugs to do with using the wrong generic fetch code (like
> bug 406597), and is a good incremental change in the desired
> direction.
> (Perhaps this partial fix will be considered adequate for the 2.0
> release, but I think Robert does not consider that enough by itself.)

Right. We do need to merge that patch, or streams from 1.16<->1.18
servers will corrupt local 2a repositories. Its not complete, we know
of other things that can go wrong, and I think we really should nail the
door closed as much as possible.

Ian's just made a couple of windows bugs release blockers, so we may
have time to do this before they are fixed anyway.

-Rob