Comment 2 for bug 406686

Revision history for this message
Robert Collins (lifeless) wrote : Re: [Bug 406686] [NEW] get_stream_for_missing_keys does not include inventory CHK pages.

On Thu, 2009-07-30 at 02:03 +0000, John A Meinel wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1

> We send:
> 1) The minimal chk pages based on a delta comparison
> 2) When we need fallback inventories we send *all possible referenced*
> pages from the parent inventories.

Where does 2) happen - I couldn't find it. Is it in
self._get_inventory_stream ?

Ah yes, it is. So the problem is that the *generic* code path doesn't do
the right thing here.

We can fix it for now by teaching RemoteStreamSource to make a new
StreamSource and implement get_stream_for_missing_keys itself.

-Rob