Bazaar

  1. Bug #406597
  2. Comment #5

Comment 5 for bug 406597

Revision history for this message
Robert Collins (lifeless) wrote : Re: ACF when trying to branch from any of my canonical-identity-provider branches

So, there are a few things here.

Something has changed, I think, but I'm having trouble identifying exactly what.

Firstly, the damage is this: we're ending up in get_stream_for_missing_keys which is not defined on RemoteStreamSource. CHKStreamSource doesn't override it, so this isn't the problem. However there is a bug that if CHKStreamSource *did* define it this wouldn't work. Removing the CHK specific source will fix that, and Andrew and I want to do that - or at least make it a requirement that the common code path *always* work even if it might be slower.

To end up in get_stream_for_missing_keys, the missing_parents_chain in the RemoteSourceStream has to be exiting successfully but not delivering everything.

And to not get an error from the target, some validation code must be missing or broken in the StreamSink code path. I'm going to focus on why the error isn't caught earlier, for now.