Comment 4 for bug 402022

Revision history for this message
Martin Pool (mbp) wrote :

The specific problem is that bzr has added a 'cleanups' parameter to _do_preview, and qbzr is overriding this method and doesn't support it. The idea is that this list can be mutated if more things need to be cleaned, and they'll eventually all be run before the command exits. I suppose for things like dirstate locking this is more reilable than relying on gc - and anyhow we discourage relying on it.

One option would be to put the cleanups into the state of the command object; that's arguably cleaner than passing it around just in case it's needed.