Comment 5 for bug 346677

Revision history for this message
Martin Pool (mbp) wrote : Re: [Bug 346677] Re: confusing message about launchpad-login, even when doing readonly access to a public branch

On 20 June 2010 20:40, danstowell <email address hidden> wrote:
> This issue just affected me, I was troubleshooting a complex auto-
> install and spent a while investigating the wrong thing thanks to the
> current message :)
>
> It's an easy fix but still seems to be open. It gets my vote. I just
> downloaded the bzr trunk of bzr and grepped around but I couldn't work
> out where the strings are defined - could someone tell me please, and
> I'll send a patch?

If you just want to change the string, it's in
bzrlib/plugins/launchpad/lp_directory.py

However a real fix for this bug probably requires teaching bzr whether
it's going to need read access or read/write access at the moment it
opens the transport. That will also make some other messages clearer
including one about locking over http. You could start an rfc thread
to ask whether people see any problems with this. Perhaps we would
want get_transport(...readonly=True) and then we can give the warning
about Launchpad only in the case that is true.

--
Martin