Comment 6 for bug 316357
Revision history for this message
| Martin Pool (mbp) wrote Re: [Bug 316357] Re: SIGWINCH support for progress bar | #6 |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
a60fb26
(Get the code!)
2009/12/10 John A Meinel <email address hidden>:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Vincent Ladeuil wrote:
>> The associated branch contains a trivial implementation to catch
>> SIGWINCH.
>>
>> I tested it by running 'bzr selftest -s bt.test_http' and this reveals a
>> fundamental flaw: catching the signal can interrupt an IO and if the
>> code base is not ready to handle that, we can get weird failures.
>>
>> I don't know if it's worth handling for a cosmetic benefit but people
>> can play with it in a plugin if they really want and have valid use
>> cases for that.
>>
>> ** Branch linked: lp:~vila/bzr/316357-SIGWINCH
>
> I thought most of our IO cases trapped EINTR. At least, I thought we
> tried to do that.
If we have any code that doesn't handle eintr, it can obviously fail
in other cases. Catching this may make it somewhat more likely but
probably not a lot. So let's do it.
--
Martin <http://