Bazaar

  1. Bug #251352
  2. Comment #9

Comment 9 for bug 251352

Revision history for this message
John A Meinel (jameinel) wrote : Re: [merge][#251352] better messages for illegal 'log -m' arguments

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Martin Pool wrote:
> Based on Anne Mohsen's patch in
> <https://bugs.edge.launchpad.net/bzr/+bug/251352> this gives a nicer
> message when the user gives an illegal regexp. (Thanks, Anne.) It
> also separates out a function re_compile_checked that we should use
> whenever compiling a user-supplied regexp because the python default
> error is not very helpful.
>
> I haven't added this into the ignore code (yet) because it's not
> directly applicable and that code already makes some effort not to
> compile them one by one for the sake of speed.
>
>

BB:approve

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAknIPukACgkQJdeBCYSNAAMtNgCg0gUpkv0q4DFaWeSo+7a2+wDj
KGsAoIWFQjiwsLAPV7JVtsAumBpbYJBF
=1QXc
-----END PGP SIGNATURE-----