Comment 4 for bug 242510

On Thu, 2008-09-18 at 22:58 +0000, John A Meinel wrote:
>
> What happens is that it pushes together 55+30+24 = 109 (it is okay
> with
> a single-pack worth of overflow). It then tries to combine the "size
> 1"
> pack into a pack of size 10. However, there is nothing else for it to
> combine with, so it just goes ahead and creates a new pack that has
> exactly the same content.
>
> And thus the target pack name already exists, and everything aborts.
>
> There are a few different ways to handle this, Robert mentioned one
> about making the packer try harder. We could also detect that we are
> not
> changing anything and just not try to repack that object.

Specifically, I was suggesting that just making a single 110 rev pack is
better - its less work and round trips. That would avoid this.

Also, checking that if we're autopacking with a single pack input, do
nothing, might be a good guard (though be sure not to prevent reconcile
from reconciling a fully packed repository).

--
GPG key available at: <http://www.robertcollins.net/keys.txt>.