Comment 25 for bug 215674

Revision history for this message
Jelmer Vernooij (jelmer) wrote :

fwiw, the gtk bit of this looks ok to me (bb:tweak), apart from the reformatting.

The patch to bzrlib looks ok in general, but needs some more changes than the gtk one; the inline unpacking of the file-info revision property in uncommit.py seems wrong to me; it should use some other shared function to unpack that property. The bzrlib patch also needs tests, at least for storing and retrieving messages using SavedCommitMessageManager. It should also just store commit messages in a generic configuration variable rather than one starting with gtk_.