Comment 39 for bug 198646

Revision history for this message
Vincent Ladeuil (vila) wrote :

> Just tried a quick shot at it, but I can't get my head into your test suite that easily.

Hmm, yeah, test_http is not the easiest to start with :-/

> I fail to see how to add a new test class to test_http.py. Are you guys hanging out on IRC somewhere?

Yup, #bzr on freenode.

> The problem, as I understand it currently, should have been covered by TruncatedMultipleRangeRequestHandler. I don't understand why it didn't catch it.

Probably because it's different enough or we would not have encounter the bug ;-)

If you're willing to keep working on it, I'd gladly help you. The best way for that would be to push your branch and make a merge proposal so we can continue the discussion there instead of here. It also make is easier to collaborate on this branch. Roughly, in the directory where you committed your changes:

  bzr push lp:~dirk-miriup/bzr/198646-missing-boundary

will create a branch on launchpad

  bzr lp-propose

will help you create the merge proposal or just do:

  bzr lp-open

and click the 'Propose for merging' link.