Comment 64 for bug 186920

Revision history for this message
John A Meinel (jameinel) wrote : Re: [Bug 186920] Re: bzr xmlrpc client doesn't use http proxy, causing network errors trying to resolve lp: urls

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 8/20/2010 6:12 AM, shypike wrote:
> John A Meinel wrote:
> It is a long-standing bug that the xmlrpc library that is built into python doesn't support http proxies.
>
> According to the Python documentation the xmlrpc library *does* support proxies.
> However, some extra effort is required.
> http://docs.python.org/library/xmlrpclib.html
> Section 20.23.9 contains an example of proxy usage.
>

ServerProxy doesn't look to be the same thing as an HTTP Proxy.

ServerProxy is a proxy-object that sends its calls to a remote machine.
(so you call obj.foo() and it actually sends an XMLRPC request, it is
'proxying' for the rpc)

An HTTP Proxy is about sending the HTTP request to this machine, telling
it you really want the data from *that* machine.

Very different things.

There is the statement about:
 class ProxiedTransport(xmlrpclib.Transport):

Which is basically what we did. Except after doing it, python2.7 changed
the internals a bit, and broke our custom Transport implementation.

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkxyk4IACgkQJdeBCYSNAAPG8QCgz6rXGh0/EdQWEh2BhpoY9DDg
+UkAn3dYE9mEL7Yr4zZoZc0l5Z/X/NZ8
=I4gY
-----END PGP SIGNATURE-----