Comment 7 for bug 152811

Revision history for this message
Marius Kruger (amanica) wrote : more info

On 11/1/07, Warren Togami <email address hidden> wrote:

    I did "bzr rm file" in directory "config", then tried "bzr rm config"
    when this crash occurred.

    Warren Togami
    <email address hidden>

    [warren@newcaprica ltsp5]$ bzr rm config/
    bzr: ERROR: exceptions.TypeError: expected string or buffer

    Traceback (most recent call last):
       File "/usr/lib64/python2.5/site-packages/bzrlib/commands.py", line
    800, in run_bzr_catch_errors
         return run_bzr(argv)
       File "/usr/lib64/python2.5/site-packages/bzrlib/commands.py", line
    758, in run_bzr
         ret = run(*run_argv)
       File "/usr/lib64/python2.5/site-packages/bzrlib/commands.py", line
    492, in run_argv_aliases
         return self.run(**all_cmd_args)
       File "/usr/lib64/python2.5/site-packages/bzrlib/builtins.py", line
    1121, in run
         force=file_deletion_strategy=='force')
       File "/usr/lib64/python2.5/site-packages/bzrlib/mutabletree.py", line
    50, in tree_write_locked
         return unbound(self, *args, **kwargs)
       File "/usr/lib64/python2.5/site-packages/bzrlib/workingtree.py", line
    1847, in remove
         if not self.is_ignored(path[1]) and (
       File "/usr/lib64/python2.5/site-packages/bzrlib/workingtree.py", line
    1604, in is_ignored
         return self._ignoreglobster.match(filename)
       File "/usr/lib64/python2.5/site-packages/bzrlib/globbing.py", line
    213, in match
         match = regex.match(filename)
    TypeError: expected string or buffer

    bzr 0.91.0 on python 2.5.1.final.0 (linux2)
    arguments: ['/usr/bin/bzr', 'rm', 'config/']

    ** please send this report to <email address hidden>

On 11/6/07, Kent Gibson <email address hidden> wrote:

    -----BEGIN PGP SIGNED MESSAGE-----
    Hash: SHA1

    Hi Warren,

    That is certainly a bug. I haven't debugged it fully but a None is
    being passed to Globster.match which expects a filename. That only
    appears to happen if there are pending (uncommitted) removed files in
    the directory being deleted, as in your case.