Robert Collins пишет:
> On Fri, 2007-11-09 at 08:08 +0000, Alexander Belchenko wrote:
>> The real problem in original traceback:
>> Some code try to create directory `c1` when this directory already
>> exists. On Windows it's error. May be on Linux it's not error, I don't
>> know. Why some code try to create `c1` again -- I don't know. May be
>> it's incorrect usage of bzrlib API from svn plugin, or may be bzrlib
>> API is not completely windows-friendly in this aspect.
>
> It's definately an error on windows too;
s/windows/linux/ ?
> I think the error code raised
> changed in a python version bump on Windows?.
Yes, it's True. Python 2.5 uses windows native error codes instead of unix-like ones where possible.
But as you could see _translate_error() function correctly translate this error to FileExists.
Excerpt from MSDN, page with system error codes:
183 | Cannot create a file when that file already exists. | ERROR_ALREADY_EXISTS
> Anyhow, packs don't suffer
> this...
Then we could close this bug when packs will become standard format?
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Robert Collins пишет:
> On Fri, 2007-11-09 at 08:08 +0000, Alexander Belchenko wrote:
>> The real problem in original traceback:
>> Some code try to create directory `c1` when this directory already
>> exists. On Windows it's error. May be on Linux it's not error, I don't
>> know. Why some code try to create `c1` again -- I don't know. May be
>> it's incorrect usage of bzrlib API from svn plugin, or may be bzrlib
>> API is not completely windows-friendly in this aspect.
>
> It's definately an error on windows too;
s/windows/linux/ ?
> I think the error code raised
> changed in a python version bump on Windows?.
Yes, it's True. Python 2.5 uses windows native error codes instead of unix-like ones where possible.
But as you could see _translate_error() function correctly translate this error to FileExists.
Excerpt from MSDN, page with system error codes:
183 | Cannot create a file when that file already exists. | ERROR_ALREADY_ EXISTS
> Anyhow, packs don't suffer
> this...
Then we could close this bug when packs will become standard format?
-----BEGIN PGP SIGNATURE----- enigmail. mozdev. org
338mxwCURAjg+ AJ9+kHQ38O/ MiFxDU05kCzmB4d ZBHACeOLau RMpJlZn0=
Version: GnuPG v1.4.6 (MingW32)
Comment: Using GnuPG with Mozilla - http://
iD8DBQFHNKvbzYr
s8y6c+cWgiqzRsP
=w52y
-----END PGP SIGNATURE-----