XSS vulnerability in Jenkins error pages when running in standalone mode

Bug #889181 reported by James Page
258
This bug affects 1 person
Affects Status Importance Assigned to Milestone
jenkins (Ubuntu)
Fix Released
Undecided
James Page
Oneiric
Fix Released
High
Unassigned
Precise
Fix Released
Undecided
James Page
jenkins-winstone (Ubuntu)
Fix Released
Undecided
Unassigned
Oneiric
Fix Released
High
Unassigned
Precise
Fix Released
Undecided
Unassigned

Bug Description

Jenkins pre 1.409.3 has a cross site scripting security vulnerability in the error pages provided by the winstone servlet container that Jenkins runs in when running in standalone mode:

See http://www.cloudbees.com/jenkins-advisory/jenkins-security-advisory-2011-11-08.cb for more details

This will require a fix into the jenkins-winstone package (already in uploaded to Debian and synced to precise for current development) and a rebuild of jenkins to pickup the new version of this library to resolve the issue for oneiric.

Revision history for this message
James Page (james-page) wrote :
Changed in jenkins-winstone (Ubuntu Oneiric):
status: New → Fix Released
Changed in jenkins (Ubuntu Oneiric):
status: New → In Progress
assignee: nobody → James Page (james-page)
Changed in jenkins-winstone (Ubuntu Oneiric):
importance: Undecided → High
Changed in jenkins (Ubuntu Oneiric):
importance: Undecided → High
Revision history for this message
James Page (james-page) wrote :

This fix is currently blocked in Oneiric due to broken versions of the toolchain required to build Jenkins.

Working on resolving this issue upstream;

visibility: private → public
Changed in jenkins-winstone (Ubuntu Precise):
status: New → Triaged
Changed in jenkins (Ubuntu Precise):
status: New → Triaged
James Page (james-page)
Changed in jenkins-winstone (Ubuntu Precise):
status: Triaged → Fix Released
Changed in jenkins-winstone (Ubuntu Oneiric):
status: Fix Released → Fix Committed
status: Fix Committed → In Progress
Changed in jenkins (Ubuntu Precise):
status: Triaged → In Progress
assignee: nobody → James Page (james-page)
Changed in jenkins-winstone (Ubuntu Oneiric):
assignee: nobody → James Page (james-page)
Revision history for this message
James Page (james-page) wrote :

So #2 should have read 'blocked in Precise'; this is now resolved.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package jenkins - 1.409.3-0ubuntu1

---------------
jenkins (1.409.3-0ubuntu1) precise; urgency=low

  * New upstream release:
    - Refreshed patches.
    - d/maven.rules: Updated jenkins version to 1.409.3.
  * Pickup new version of jenkins-winstone resolving XSS security
    vulnerability (LP: #889181).
  * d/patches/build/apt-stapler-processing.patch: Temporary patch to fix
    build when using later versions of stapler which use standard
    Java annotation processing.
 -- James Page <email address hidden> Tue, 22 Nov 2011 08:31:53 +0000

Changed in jenkins (Ubuntu Precise):
status: In Progress → Fix Released
Revision history for this message
Jamie Strandboge (jdstrand) wrote :

Thank for updating this James. Are you still planning on providing updates for 11.10? If so, can you follow https://wiki.ubuntu.com/SecurityTeam/SponsorsQueue#Notes_for_Contributors so that it shows up on our radar? Thanks!

Revision history for this message
James Page (james-page) wrote :
Revision history for this message
James Page (james-page) wrote :
Revision history for this message
James Page (james-page) wrote :

I've done a basic commission of 1.409.1-0ubuntu4.1 on oneiric and the fix to jenkins-winstone does not appear to have regressed any functionality.

Changed in jenkins (Ubuntu Oneiric):
status: In Progress → Confirmed
Changed in jenkins-winstone (Ubuntu Oneiric):
status: In Progress → Confirmed
Changed in jenkins (Ubuntu Oneiric):
assignee: James Page (james-page) → nobody
Changed in jenkins-winstone (Ubuntu Oneiric):
assignee: James Page (james-page) → nobody
Revision history for this message
James Page (james-page) wrote :

Un-assigning myself and marking as 'Confirmed' so that this bug shows up on the sponsors queue.

Revision history for this message
Jamie Strandboge (jdstrand) wrote :

Thanks for your patches! They look great and I have uploaded them to the security ppa. Per irc, it would be good to get htmlunit working again and then re-enable the tests the next time this is updated. Thanks again!

Changed in jenkins-winstone (Ubuntu Oneiric):
status: Confirmed → Fix Committed
Changed in jenkins (Ubuntu Oneiric):
status: Confirmed → Fix Committed
Revision history for this message
Jamie Strandboge (jdstrand) wrote :
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package jenkins - 1.409.1-0ubuntu4.1

---------------
jenkins (1.409.1-0ubuntu4.1) oneiric-security; urgency=low

  * SECURITY UPDATE: Rebuild to pickup new version of jenkins-winstone
    to close out XSS security vulnerability (LP: #889181).
 -- James Page <email address hidden> Tue, 22 Nov 2011 13:04:34 +0000

Changed in jenkins (Ubuntu Oneiric):
status: Fix Committed → Fix Released
Revision history for this message
Jamie Strandboge (jdstrand) wrote :

jenkins-winstone (0.9.10-jenkins-25+dfsg-0ubuntu2.1) oneiric-security; urgency=low

  * SECURITY UPDATE: XSS vulnerability in default error pages.
    - debian/patches/fix_xss.patch: escape error messages which are supposed
      be plain text and not markup in
      src/java/winstone/ErrorServlet.java,
      src/java/winstone/URIUtil.java,
      src/java/winstone/WinstoneResponse.java
    - http://www.cloudbees.com/jenkins-advisory/jenkins-security-advisory-2011-11-08.cb
  * d/maven.{properties,ignoreRules}: Disabled testing as htmlunit is
    currently broken in 11.10.

Changed in jenkins-winstone (Ubuntu Oneiric):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public Security information  
Everyone can see this security related information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.