Launchpad itself

Tab (facet) text should not be customizable

Bug #87497 reported by Matthew Paul Thomas
2
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Undecided
Unassigned

Bug Description

For each type of browsable object, each facet has a text= attribute that cannot even be omitted. The reverse should be true: the tab text should be specified once in the Launchpad code, and should not be customizable.

See however bug 185030.

See original description
Matthew Paul Thomas (mpt)
description: updated
Revision history for this message
Gary Poster (gary) wrote :

Matthew, I'm not clear on what this means, and I wonder if it is still pertinent to the new UI. Could you either clarify or mark as invalid (or some other similar "closing" gesture)? Thank you.

Changed in launchpad-foundations:
status: New → Incomplete
Matthew Paul Thomas (mpt)
Changed in launchpad-foundations:
status: Incomplete → New
Revision history for this message
Matthew Paul Thomas (mpt) wrote :

This bug report relates to the underlying code, not to the UI.

Revision history for this message
Guilherme Salgado (salgado) wrote :

I think the text of facets is now defined only once in StandardLaunchpadFacets (lib/c/l/webapp/__init__.py), so this is indeed invalid.

Revision history for this message
Gary Poster (gary) wrote :

I looked at the file and that looks right to me. Thank you Salgado. Matthew, if you have reason to think otherwise, please let us know, but for now I will mark as invalid.

Changed in launchpad-foundations:
status: New → Invalid
Revision history for this message
Matthew Paul Thomas (mpt) wrote :

It seems to be a common error, lately, for Launchpad developers to mark bugs that have been fixed as Invalid rather than Fixed. For the facet text to be defined only once is *precisely* what this bug report was asking for.

Changed in launchpad-foundations:
status: Invalid → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.