Ubuntu
indicator-sound package

"Sound Preferences..." should be "Sound Settings"

Bug #785571 reported by Jeremy Bícha
20
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Ayatana Design
Fix Released
Undecided
Unassigned
The Sound Menu
Fix Released
Undecided
Conor Curran
The Sound Menu 0.7.1
indicator-sound (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

Binary package hint: indicator-sound

Ubuntu's system menus ("indicators") are inconsistent in how settings are changed. The primary settings are set in the session menu's "System Settings", time is changed in "Time and Date Preferences", password is changed in "About Me" and the bluetooth menu just uses "Preferences". I suggest we follow Gnome Shell's example and use "__ Settings" for each of these.

The Gnome HIG is clear that Settings & Preferences buttons should not have ellipsis, as ellipsis implies further input is required. http://developer.gnome.org/hig-book/unstable/controls-buttons.html.en

The button should therefore be "Sound Settings."

ProblemType: Bug
DistroRelease: Ubuntu 11.10
Package: indicator-sound 0.6.6.1-0ubuntu3
ProcVersionSignature: Ubuntu 2.6.39-2.8-generic 2.6.39-rc7
Uname: Linux 2.6.39-2-generic x86_64
Architecture: amd64
Date: Fri May 20 02:22:29 2011
InstallationMedia: Ubuntu 10.10 "Maverick Meerkat" - Release amd64 (20101007)
ProcEnviron:
 LANGUAGE=en_GB:en
 PATH=(custom, no user)
 LANG=en_GB.utf8
 SHELL=/bin/bash
SourcePackage: indicator-sound
UpgradeStatus: Upgraded to oneiric on 2011-01-01 (139 days ago)

Related branches

lp:~jbicha/indicator-sound/785571-rename-sound-settings
Conor Curran (community): Approve
Diff: 12 lines (+1/-1)
1 file modified
src/sound-service-dbus.c (+1/-1)
lp:ubuntu/oneiric/indicator-sound
Revision history for this message
Jeremy Bícha (jbicha) wrote :
Revision history for this message
Jeremy Bícha (jbicha) wrote :

Merge proposal included. And I'm attaching a screenshot from Gnome Shell.

Revision history for this message
Robert Roth (evfool) wrote :

This clearly is a really nice consistency issue.
- We have System settings in the session indicator without ellipsis
- Broadcast accounts... and About me... in the me menu with ellipsis
- Time & Date Settings... in indicator-datetime with ellipsis
- Network settings... in the connman-based network indicator (although this is not a default, don't know anything about the nm)
- Keyboard Preferences without ellipsis in the keyboard layout indicator
So right now it seems very inconsistent to me. I did not know about the HIG mentioning this, but I do consider this a very nice thing to comply with to reduce the inconsistency.

Conor Curran (cjcurran)
Changed in ayatana-design:
status: New → Fix Committed
Changed in indicator-sound:
status: New → Fix Committed
milestone: none → 0.7.1
assignee: nobody → Conor Curran (cjcurran)
Changed in indicator-sound (Ubuntu):
status: New → In Progress
Revision history for this message
Vish (vish) wrote :

@Conor Curran, before committing this branch I suggest you get an ACK from mpt.
He does not like that part of the HIG and several designs in Ubuntu/Ayatana intentionally do not follow that part of the HIG. Which is the reason why all the menu items Robert points out in comment #3 have ellipses.

@Robert Roth, system settings should get an ellipses and iirc there is a bug for that already somewhere.

Revision history for this message
Vish (vish) wrote :

Oh! and also, mpt dint design System Settings item in the menu there, hence it did not have the ellipses ;-)

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package indicator-sound - 0.7.1-0ubuntu1

---------------
indicator-sound (0.7.1-0ubuntu1) oneiric; urgency=low

  * New upstream release.
    - "Sound Preferences..." should be "Sound Settings" (LP: #785571)
    - Not obvious what track info menu item does (LP: #699899)
  * debian/patches/lp_750823.patch
    - Dropped patch, merged upstream
  * debian/control
    - Updated standards version to 3.9.2
    - Cleaned up description to quiet lintian
 -- Ken VanDine <email address hidden> Thu, 16 Jun 2011 21:21:27 -0400

Changed in indicator-sound (Ubuntu):
status: In Progress → Fix Released
Revision history for this message
Matthew Paul Thomas (mpt) wrote :

The reason all the settings items end in ellipses is that the primary goal, changing the settings, requires further input after you select the menu item. The Gnome HIG is internally inconsistent about this, which I reported as a bug in 2005. <https://bugzilla.gnome.org/show_bug.cgi?id=169447>

I have updated the specification to refer to "Sound Settings…" rather than "Sound Preferences…". <https://wiki.ubuntu.com/SoundMenu?action=diff&rev2=63&rev1=62>

Revision history for this message
Jeremy Bícha (jbicha) wrote :

@mpt thanks for the explanation. I presume the System Settings link in the session menu will be getting ellipses also?

Conor Curran (cjcurran)
Changed in indicator-sound:
status: Fix Committed → Fix Released
Changed in ayatana-design:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.